Bug 43981 - Test tubes/offer-private-stream-tube.py failing in buildbot
Summary: Test tubes/offer-private-stream-tube.py failing in buildbot
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://cgit.freedesktop.org/~jonny/te...
Whiteboard: nearly review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-12-20 07:16 UTC by Alvaro Soliverez
Modified: 2012-01-31 08:42 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
tubetestutil: clear list in a way that doesn't make it a local variable (795 bytes, patch)
2012-01-31 03:37 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Alvaro Soliverez 2011-12-20 07:16:02 UTC 
This test is failing in buildbot, with the following error:

Traceback (most recent call last):
  File "/var/lib/buildbot/telepathy/gabble-default-i386/build/build/telepathy-gabble-0.15.1.1/tests/twisted/gabbletest.py", line 634, in exec_test_deferred
    fun(queue, bus, conns[0], streams[0])
  File "/var/lib/buildbot/telepathy/gabble-default-i386/build/build/telepathy-gabble-0.15.1.1/tests/twisted/tubes/tubetestutil.py", line 366, in <lambda>
    test(q, bus, conn, stream, bytestream_cls, *args))
  File "../../../tests/twisted/tubes/offer-private-stream-tube.py", line 44, in test
    address1 = t.set_up_echo(q, address_type, True, streamfile='stream')
  File "/var/lib/buildbot/telepathy/gabble-default-i386/build/build/telepathy-gabble-0.15.1.1/tests/twisted/tubes/tubetestutil.py", line 241, in set_up_echo
    return create_server(q, address_type, factory, streamfile=streamfile)
  File "/var/lib/buildbot/telepathy/gabble-default-i386/build/build/telepathy-gabble-0.15.1.1/tests/twisted/tubes/tubetestutil.py", line 288, in create_server
    reactor.listenUNIX(path, factory)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/posixbase.py", line 380, in listenUNIX
    p.startListening()
  File "/usr/lib/python2.6/dist-packages/twisted/internet/unix.py", line 120, in startListening
    raise CannotListenError, (None, self.port, le)
CannotListenError: Couldn't listen on any:/var/lib/buildbot/telepathy/gabble-default-i386/build/build/telepathy-gabble-0.15.1.1/_build/tests/twisted/stream: AF_UNIX path too long.
FAIL: tubes/offer-private-stream-tube.py

See: http://buildbot.telepathy.im/builders/Gabble%20-%20default%20-%20i386/builds/164/steps/Tests/logs/stdio
Comment 1 Jonny Lamb 2011-12-21 06:01:07 UTC 
This should make things work.

Not sure about the cleanup thing. What do people think?
Comment 2 Jonny Lamb 2011-12-21 06:01:27 UTC 
(Obviously this goes on the assumption that a temp file isn't created in the biggest path evah.)
Comment 3 Simon McVittie 2012-01-30 10:36:41 UTC 
r+ if you make _to_cleanup empty its list so it's idempotent?
Comment 4 Jonny Lamb 2012-01-30 11:41:43 UTC 
(In reply to comment #3)
> r+ if you make _to_cleanup empty its list so it's idempotent?

Good point. Done and dusted^Wpushed.
Comment 5 Simon McVittie 2012-01-31 03:37:48 UTC 
Created attachment 56368 [details] [review]
tubetestutil: clear list in a way that doesn't make it a local variable

(In reply to comment #4)
> Good point. Done and dusted^Wpushed.

Turns out not to work, see attached.
Comment 6 Jonny Lamb 2012-01-31 08:29:48 UTC 
(In reply to comment #5)
> Turns out not to work, see attached.

Yes yes, I suck. Sorry. :-(

r+

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.