Bug 4443

Summary: Leak in miext/shadow.c
Product: xorg Reporter: Søren Sandmann Pedersen <soren.sandmann>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: high    
Version: 6.8.2   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
patch eric: 6.8-branch+

Description Søren Sandmann Pedersen 2005-09-13 08:31:29 UTC 
There is a missing REGION_UNINIT in the function shadowDamageBox() in 
miext/shadow.c.

The obvious fix;
     
     REGION_UNINIT (pWindow->drawable.pScreen, &region);

has already been committed to HEAD.
Comment 1 Søren Sandmann Pedersen 2005-09-13 08:32:03 UTC 
Created attachment 3249 [details] [review]
patch
Comment 2 Søren Sandmann Pedersen 2005-09-13 08:33:01 UTC 
Comment on attachment 3249 [details] [review]
patch

flagging for 6.8.x approval
Comment 3 Eric Anholt 2005-09-15 19:16:19 UTC 
Comment on attachment 3249 [details] [review]
patch

this is pretty clearly correct.
Comment 4 Eric Anholt 2006-04-04 18:11:05 UTC 
6.8.x is pretty freakin' dead at this point.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.