Bug 4443 - Leak in miext/shadow.c
Summary: Leak in miext/shadow.c
Status: RESOLVED WONTFIX
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 6.8.2
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-13 08:31 UTC by Søren Sandmann Pedersen
Modified: 2006-04-04 01:11 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch (1.17 KB, patch)
2005-09-13 08:32 UTC, Søren Sandmann Pedersen 		eric: 6.8-branch+
Details | Splinter Review
View All

Description Søren Sandmann Pedersen 2005-09-13 08:31:29 UTC 
There is a missing REGION_UNINIT in the function shadowDamageBox() in 
miext/shadow.c.

The obvious fix;
     
     REGION_UNINIT (pWindow->drawable.pScreen, &region);

has already been committed to HEAD.
Comment 1 Søren Sandmann Pedersen 2005-09-13 08:32:03 UTC 
Created attachment 3249 [details] [review]
patch
Comment 2 Søren Sandmann Pedersen 2005-09-13 08:33:01 UTC 
Comment on attachment 3249 [details] [review]
patch

flagging for 6.8.x approval
Comment 3 Eric Anholt 2005-09-15 19:16:19 UTC 
Comment on attachment 3249 [details] [review]
patch

this is pretty clearly correct.
Comment 4 Eric Anholt 2006-04-04 18:11:05 UTC 
6.8.x is pretty freakin' dead at this point.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.