Bug 4488

Summary:	Fix overlay scaler (xv) in presence of Composite in Xorg server.
Product:	xorg	Reporter:	Eric Anholt <eric>
Component:	Server/DDX/Xorg	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED FIXED	QA Contact:	Xorg Project Team <xorg-team>
Severity:	enhancement
Priority:	high	CC:	alexdeucher, basic, bni.swe, brodzky, ghepeu, marejde, michel, sangu.xorg
Version:	git
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Eric Anholt 2005-09-17 12:10:45 UTC

As has been reported widely, XV (with overlay scalers) doesn't work like people
expect in the presence of Composite.  It would be nice to get this basically
working, and there are a few things to do:
- redirect the drawing of color keys to backing store.  xf86XV* functions could
get this done for us, I think.
- standardize on a window manager hint to say "please don't blend over me, it's
really imporant," which the compositing manager could pick up on.

This would make it so we don't render XV totally wrong (wrong color showing
through, blended color key showing through) but not deal with letting people do
arbitrary transformations on XV output.

This bug exists to clearly state what (I think) we should do for now, so we can
mark as duped the bugs talking reporting this issue.

Comment 1 Eric Anholt 2005-09-17 12:11:57 UTC

*** Bug 4483 has been marked as a duplicate of this bug. ***

Comment 2 Eric Anholt 2005-09-17 12:14:36 UTC

*** Bug 1151 has been marked as a duplicate of this bug. ***

Comment 3 Eric Anholt 2005-10-02 19:57:17 UTC

Here's a thought: Create the WM hint that says "paint me solid with the color
key."  If a drawable is redirected, actually paint the backing store using
textured xvideo (if available), otherwise color key.  Then, if the compmgr is
smart it'll give you overlay video (nice refreshing, etc.) and if the compmgr is
dumb you get reasonable video, and no matter what, getimage on the drawable
would do what people would expect.  I suppose this wouldn't fix programs doing
screenshots, unless they were made smarter, though.

Comment 4 Anders Storsveen 2005-10-03 03:36:26 UTC

This works perfectly in osx, should be possible in linux to with same
equivialent hardware... Even scaled as in expose...

Also, we should get someone on this soon!

Comment 5 Michel Dänzer 2005-10-03 03:41:18 UTC

(In reply to comment #4)
> This works perfectly in osx, should be possible in linux to with same
> equivialent hardware... Even scaled as in expose...

OS X doesn't use the overlay AFAIK, basically what we'd need for that would be
(properly redirected) Xv using texture blits.

> Also, we should get someone on this soon!

True, go ahead. :)

Comment 6 Michel Dänzer 2006-10-15 08:24:32 UTC

xf86XVFillKeyHelperDrawable() is available in
f9bfee50981006a2c58d3f73e2b0d123bb2a41b7. Do we still want to track the
compositing manager ideas here? I don't think the remaining limitations of
overlay adaptors are really different with/out compositing.

Comment 7 Daniel Stone 2007-02-27 01:28:04 UTC

Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.

Comment 8 Eric Anholt 2010-08-27 21:26:28 UTC

Yeah, now that the color key painting is fixed all over, this bug can die.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.