Bug 45217

Summary:	[Patch] Fix automagic dependencies in cmake
Product:	Telepathy	Reporter:	Johannes Huber <johu>
Component:	tp-qt	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	kensington
Version:	0.9
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	tp-qt-0.9.0automagic-dependencies.patch

Description Johannes Huber 2012-01-25 02:39:13 UTC

Created attachment 56130 [details] [review]
tp-qt-0.9.0automagic-dependencies.patch

$summary

Comment 1 Dario Freddi 2012-03-13 06:40:58 UTC

Thanks for the patch. It is spot on except for the tests part, which by design we don't exclude (otherwise several targets would be broken). Is it ok for you if I committed a modified version of this patch without an option for tests, and eventually one for examples (which instead would make quite sense)?

Comment 2 Johannes Huber 2012-03-13 07:07:25 UTC

(In reply to comment #1)
> Thanks for the patch. It is spot on except for the tests part, which by design
> we don't exclude (otherwise several targets would be broken). Is it ok for you
> if I committed a modified version of this patch without an option for tests,
> and eventually one for examples (which instead would make quite sense)?

Yeah just do it, thanks.

Comment 3 Michael 2012-04-19 03:50:00 UTC

After much poking, I have made some changes[1] to Johannes' patch to clarify dependencies and add an option to control examples.

These changes are in branch 'automagic' on GitHub[2].

[1]: https://github.com/kensington/telepathy-qt/commit/8a1372dfca0d827b4b8e4a07499fb3d3cf3758b8
[2]: git://github.com/kensington/telepathy-qt.git

Comment 4 Michael 2012-04-19 03:59:37 UTC

(In reply to comment #1)
> Thanks for the patch. It is spot on except for the tests part, which by design
> we don't exclude (otherwise several targets would be broken).

Which targets break? During testing, I didn't notice any breakage of the default target.

In any case, the patch adding options leave everything on by default - as per the current behaviour.

Comment 5 Alexandr Akulich 2015-04-23 11:12:08 UTC

Commit 2062d6dd986e6f626f06b4d9c82e99bdbf569eab

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.