Created attachment 56130 [details] [review] tp-qt-0.9.0automagic-dependencies.patch $summary
Thanks for the patch. It is spot on except for the tests part, which by design we don't exclude (otherwise several targets would be broken). Is it ok for you if I committed a modified version of this patch without an option for tests, and eventually one for examples (which instead would make quite sense)?
(In reply to comment #1) > Thanks for the patch. It is spot on except for the tests part, which by design > we don't exclude (otherwise several targets would be broken). Is it ok for you > if I committed a modified version of this patch without an option for tests, > and eventually one for examples (which instead would make quite sense)? Yeah just do it, thanks.
After much poking, I have made some changes[1] to Johannes' patch to clarify dependencies and add an option to control examples. These changes are in branch 'automagic' on GitHub[2]. [1]: https://github.com/kensington/telepathy-qt/commit/8a1372dfca0d827b4b8e4a07499fb3d3cf3758b8 [2]: git://github.com/kensington/telepathy-qt.git
(In reply to comment #1) > Thanks for the patch. It is spot on except for the tests part, which by design > we don't exclude (otherwise several targets would be broken). Which targets break? During testing, I didn't notice any breakage of the default target. In any case, the patch adding options leave everything on by default - as per the current behaviour.
Commit 2062d6dd986e6f626f06b4d9c82e99bdbf569eab
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.