Bug 45410

I reviewed up to e62456367481018 - first pass, looking at the diff only, not reading the HTML.

Ultra-low-hanging fruit:

git grep Simple and consider:

s/\<Simple_Presence\>/Presence/
s/\<Simple_Status_Spec/Status_Spec/
s/\<Simple_Contact_Presences\>/Contact_Presence_Map/ (?)

git grep telepathy/ and replace with telepathy1 where it appears in object paths (at least one occurrence, in Debug)

Call the Debug object .../Debug instead of .../debug?

Remove the Detailed from HandleOwnersChangedDetailed

Hold should probably have an xor-requires on Call and Content, not a requires

Maybe rename Protocol (the typed string) to Protocol_Name to avoid confusion with Protocol objects?

Set fire to Rich_Presence_Access_Control and just use Access_Control in Location

> +    <p>The namespace <code>im.telepathy1.Qt4.Error.</code>

should be Qt.Error now?

DTMF should lose all references to stream IDs

(In reply to comment #1)
> git grep Simple
> git grep telepathy/ and replace with telepathy1 where it appears in object
> paths (at least one occurrence, in Debug)
> Call the Debug object .../Debug instead of .../debug?
> Remove the Detailed from HandleOwnersChangedDetailed
> Maybe rename Protocol (the typed string) to Protocol_Name to avoid confusion
> with Protocol objects?

All fixed on my version of the branch

> Set fire to Rich_Presence_Access_Control and just use Access_Control in
> Location
> Hold should probably have an xor-requires on Call and Content, not a requires
> > +    <p>The namespace <code>im.telepathy1.Qt4.Error.</code>
> 
> should be Qt.Error now?
> 
> DTMF should lose all references to stream IDs

Not done yet, but low-hanging

(In reply to comment #2)
> > Set fire to Rich_Presence_Access_Control and just use Access_Control in
> > Location

smcv/next-access-control does this, and also fixes the cross-references to other interfaces to make sense (including changing the argument of Group from a handle to a string, since we no longer have group handles).

(In reply to comment #3)
> (In reply to comment #2)
> > > Set fire to Rich_Presence_Access_Control and just use Access_Control in
> > > Location
> 
> smcv/next-access-control does this, and also fixes the cross-references to other interfaces to make sense (including changing the argument of Group from a
> handle to a string, since we no longer have group handles).

Looks good.

Created attachment 57215 [details] [review]
Change maintainer-upload-snapshot to upload to a  parallel location

---

(In reply to comment #4)
> > smcv/next-access-control does this
> 
> Looks good.

Merged, thanks. Here's my next trivial change...

Created attachment 57216 [details] [review]
Bump version to 0.99.0.1 to reflect "pre-1.0" status

---

The result of those two patches: <http://telepathy.freedesktop.org/spec-next/>

Comment on attachment 57215 [details] [review]
Change maintainer-upload-snapshot to upload to a  parallel location

Review of attachment 57215 [details] [review]:
-----------------------------------------------------------------

Looks good.

Comment on attachment 57216 [details] [review]
Bump version to 0.99.0.1 to reflect "pre-1.0" status

Review of attachment 57216 [details] [review]:
-----------------------------------------------------------------

::: spec/all.xml
@@ +137,5 @@
> +   <xi:include href="Channel_Type_Room_List1.xml"/>
> +   <xi:include href="Channel_Type_Server_Authentication1.xml"/>
> +   <xi:include href="Channel_Type_Server_TLS_Connection1.xml"/>
> +   <xi:include href="Channel_Type_Stream_Tube1.xml"/>
> +   <xi:include href="Channel_Type_Text1.xml"/>

no, Text is core.

(In reply to comment #6)
> Created attachment 57216 [details] [review] [review]
> Bump version to 0.99.0.1 to reflect "pre-1.0" status

Is this the patch you meant to submit? I found d050a81bb9d07bbe in your repo which seems very different?

Anyway I merged both patches.

Closing this bug. For more specific next problems, open another and make it block bug #23148.