Bug 45410 - Telepathy 1.0: start the 'next' branch
Summary: Telepathy 1.0: start the 'next' branch
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: git master
Hardware: Other All
: high normal
Assignee: Jonny Lamb
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: tp-spec-1.0
  Show dependency treegraph
 
Reported: 2012-01-30 10:42 UTC by Simon McVittie
Modified: 2012-04-06 15:07 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Change maintainer-upload-snapshot to upload to a parallel location (1015 bytes, patch)
2012-02-17 08:18 UTC, Simon McVittie
Details | Splinter Review
Bump version to 0.99.0.1 to reflect "pre-1.0" status (74.14 KB, patch)
2012-02-17 08:19 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2012-01-30 10:42:13 UTC
+++ This bug was initially created as a clone of Bug #23148 +++

Code review bug for Jonny's initial version of the 'next' branch. I'm reviewing it.
Comment 1 Simon McVittie 2012-01-30 11:57:54 UTC
I reviewed up to e62456367481018 - first pass, looking at the diff only, not reading the HTML.

Ultra-low-hanging fruit:

git grep Simple and consider:

s/\<Simple_Presence\>/Presence/
s/\<Simple_Status_Spec/Status_Spec/
s/\<Simple_Contact_Presences\>/Contact_Presence_Map/ (?)

git grep telepathy/ and replace with telepathy1 where it appears in object paths (at least one occurrence, in Debug)

Call the Debug object .../Debug instead of .../debug?

Remove the Detailed from HandleOwnersChangedDetailed

Hold should probably have an xor-requires on Call and Content, not a requires

Maybe rename Protocol (the typed string) to Protocol_Name to avoid confusion with Protocol objects?

Set fire to Rich_Presence_Access_Control and just use Access_Control in Location

> +    <p>The namespace <code>im.telepathy1.Qt4.Error.</code>

should be Qt.Error now?

DTMF should lose all references to stream IDs
Comment 2 Simon McVittie 2012-01-31 08:39:47 UTC
(In reply to comment #1)
> git grep Simple
> git grep telepathy/ and replace with telepathy1 where it appears in object
> paths (at least one occurrence, in Debug)
> Call the Debug object .../Debug instead of .../debug?
> Remove the Detailed from HandleOwnersChangedDetailed
> Maybe rename Protocol (the typed string) to Protocol_Name to avoid confusion
> with Protocol objects?

All fixed on my version of the branch

> Set fire to Rich_Presence_Access_Control and just use Access_Control in
> Location
> Hold should probably have an xor-requires on Call and Content, not a requires
> > +    <p>The namespace <code>im.telepathy1.Qt4.Error.</code>
> 
> should be Qt.Error now?
> 
> DTMF should lose all references to stream IDs

Not done yet, but low-hanging
Comment 3 Simon McVittie 2012-02-13 07:58:25 UTC
(In reply to comment #2)
> > Set fire to Rich_Presence_Access_Control and just use Access_Control in
> > Location

smcv/next-access-control does this, and also fixes the cross-references to other interfaces to make sense (including changing the argument of Group from a handle to a string, since we no longer have group handles).
Comment 4 Jonny Lamb 2012-02-13 10:40:21 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > > Set fire to Rich_Presence_Access_Control and just use Access_Control in
> > > Location
> 
> smcv/next-access-control does this, and also fixes the cross-references to other interfaces to make sense (including changing the argument of Group from a
> handle to a string, since we no longer have group handles).

Looks good.
Comment 5 Simon McVittie 2012-02-17 08:18:42 UTC
Created attachment 57215 [details] [review]
Change maintainer-upload-snapshot to upload to a  parallel location

---

(In reply to comment #4)
> > smcv/next-access-control does this
> 
> Looks good.

Merged, thanks. Here's my next trivial change...
Comment 6 Simon McVittie 2012-02-17 08:19:38 UTC
Created attachment 57216 [details] [review]
Bump version to 0.99.0.1 to reflect "pre-1.0" status

---

The result of those two patches: <http://telepathy.freedesktop.org/spec-next/>
Comment 7 Jonny Lamb 2012-03-01 16:34:52 UTC
Comment on attachment 57215 [details] [review]
Change maintainer-upload-snapshot to upload to a  parallel location

Review of attachment 57215 [details] [review]:
-----------------------------------------------------------------

Looks good.
Comment 8 Jonny Lamb 2012-03-01 16:47:26 UTC
Comment on attachment 57216 [details] [review]
Bump version to 0.99.0.1 to reflect "pre-1.0" status

Review of attachment 57216 [details] [review]:
-----------------------------------------------------------------

::: spec/all.xml
@@ +137,5 @@
> +   <xi:include href="Channel_Type_Room_List1.xml"/>
> +   <xi:include href="Channel_Type_Server_Authentication1.xml"/>
> +   <xi:include href="Channel_Type_Server_TLS_Connection1.xml"/>
> +   <xi:include href="Channel_Type_Stream_Tube1.xml"/>
> +   <xi:include href="Channel_Type_Text1.xml"/>

no, Text is core.
Comment 9 Jonny Lamb 2012-04-06 15:06:03 UTC
(In reply to comment #6)
> Created attachment 57216 [details] [review] [review]
> Bump version to 0.99.0.1 to reflect "pre-1.0" status

Is this the patch you meant to submit? I found d050a81bb9d07bbe in your repo which seems very different?

Anyway I merged both patches.
Comment 10 Jonny Lamb 2012-04-06 15:07:26 UTC
Closing this bug. For more specific next problems, open another and make it block bug #23148.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.