Bug 45440

Summary:	Fix return value of poppler_attachment_save()
Product:	poppler	Reporter:	Hib Eris <hib>
Component:	glib frontend	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	0001-Fix-return-value-of-poppler_attachment_save.patch

Description Hib Eris 2012-01-31 05:27:43 UTC

Going through the warnings while compiling poppler, I noticed the result variable in poppler_attachement_save() was not used at all. I think it should actually be used as the return value.

Patch follows.

Comment 1 Hib Eris 2012-01-31 05:29:11 UTC

Created attachment 56383 [details] [review]
0001-Fix-return-value-of-poppler_attachment_save.patch

Comment 2 Carlos Garcia Campos 2012-02-04 02:20:45 UTC

Comment on attachment 56383 [details] [review]
0001-Fix-return-value-of-poppler_attachment_save.patch

Review of attachment 56383 [details] [review]:
-----------------------------------------------------------------

Pushed, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.