Bug 45440 - Fix return value of poppler_attachment_save()
Summary: Fix return value of poppler_attachment_save()
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: glib frontend (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-31 05:27 UTC by Hib Eris
Modified: 2012-02-04 02:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
0001-Fix-return-value-of-poppler_attachment_save.patch (659 bytes, patch)
2012-01-31 05:29 UTC, Hib Eris 		Details | Splinter Review
View All

Description Hib Eris 2012-01-31 05:27:43 UTC 
Going through the warnings while compiling poppler, I noticed the result variable in poppler_attachement_save() was not used at all. I think it should actually be used as the return value.

Patch follows.
Comment 1 Hib Eris 2012-01-31 05:29:11 UTC 
Created attachment 56383 [details] [review]
0001-Fix-return-value-of-poppler_attachment_save.patch
Comment 2 Carlos Garcia Campos 2012-02-04 02:20:45 UTC 
Comment on attachment 56383 [details] [review]
0001-Fix-return-value-of-poppler_attachment_save.patch

Review of attachment 56383 [details] [review]:
-----------------------------------------------------------------

Pushed, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.