Summary: | cannot render on a drawable of size equal the max framebuffer size | ||
---|---|---|---|
Product: | Mesa | Reporter: | Alban Browaeys <prahal> |
Component: | Drivers/DRI/i830 | Assignee: | Default DRI bug account <dri-devel> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | ||
Version: | git | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
do not drift one pixel above what we want - x2, y2 are exclusive max
testcase for max not rendering |
Description
Alban Browaeys
2012-02-02 10:36:45 UTC
Created attachment 56551 [details]
testcase for max not rendering
This testcase is made from a mesa demo. The issue is that with WindowSize 2048 (width and height - and width or height) where the max framebuffer size is 2048 the render fails.
To clarify I meant src/mesa/drivers/dri/i915/intel_context.c: ctx->Const.MaxRenderbufferSize = 2048; not framebuffer size. That is the drawable size attached to the gl context. It is 2048 for less or equal to gen 3. So the test should be right for gen3 too. The BLT ranges are exclusive -- it's only the drawrect that has that oddness. I pushed that part of the patch, and it does almost entirely fix gnome-shell rendering. commit 7d13a6e64bf88566875a8f68e0aac9b937e30feb Author: Alban Browaeys <prahal@yahoo.com> Date: Thu Feb 2 19:20:22 2012 +0100 dri/i915: Fix off-by-one in i830 clip region size. The hardware, like i915, uses an inclusive bounds on min and max for the drawing rectangle, but we were providing a number for exclusive. The number of bits used by the hardware only covers this value going up to the maximum size, so when we programmed 2048 as the maximum inclusive X, it saw a maximum X of 0 and clipped all rendering. This caused rendering failures in gnome-shell. Fixes piglit fbo-maxsize. v2: dropped changes to the blitter, which does use an exclusive x2, y2. [change by anholt] Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45558 Reviewed-by: Eric Anholt <eric@anholt.net> NOTE: This is a candidate for release branches. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.