| Summary: | incorrect constant used with pipe_resource field? | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Julia Lawall <jlawall> |
| Component: | Other | Assignee: | mesa-dev |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | 7.11 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Yes that's wrong, it should be 'usage' (the function arg), not 'pr->flags'. Note: nvfx gallium driver has been abandoned and removed with 66c7dc5688bcd5ff9c596f4c410aee574ea2428a . It got replaced by the new nv30 gallium driver. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
In gallium/drivers/nvfx/nvfx_transfer.c, the function nvfx_transfer_inline_write contains the code: nvfx_buffer_dirty_interval(buffer, begin, size, !!(pr->flags & PIPE_TRANSFER_UNSYNCHRONIZED)); Elsewhere nearby the flags field of a pipe_resource structure is used with constants like NVFX_RESOURCE_FLAG_LINEAR and PIPE_TRANSFER_UNSYNCHRONIZED is used with the usage field of a pipe_transfer structure. So perhaps there is a problem here?