Bug 45622 - incorrect constant used with pipe_resource field?
Summary: incorrect constant used with pipe_resource field?
Status: RESOLVED WONTFIX
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: 7.11
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-04 08:43 UTC by Julia Lawall
Modified: 2012-09-13 11:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Julia Lawall 2012-02-04 08:43:18 UTC 
In gallium/drivers/nvfx/nvfx_transfer.c, the function nvfx_transfer_inline_write contains the code:

                nvfx_buffer_dirty_interval(buffer, begin, size,
                                !!(pr->flags & PIPE_TRANSFER_UNSYNCHRONIZED));

Elsewhere nearby the flags field of a pipe_resource structure is used with constants like NVFX_RESOURCE_FLAG_LINEAR and PIPE_TRANSFER_UNSYNCHRONIZED is used with the usage field of a pipe_transfer structure.  So perhaps there is a problem here?
Comment 1 Christoph Bumiller 2012-02-05 07:42:29 UTC 
Yes that's wrong, it should be 'usage' (the function arg), not 'pr->flags'.
Comment 2 Andreas Boll 2012-09-13 11:30:40 UTC 
Note: nvfx gallium driver has been abandoned
and removed with 66c7dc5688bcd5ff9c596f4c410aee574ea2428a .
It got replaced by the new nv30 gallium driver.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.