Bug 4593

Summary:	LOGFONT::lfHeight should be set negative to make font correct size
Product:	cairo	Reporter:	Tor Lillqvist <tml>
Component:	win32 backend	Assignee:	Owen Taylor <otaylor>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	high
Version:	1.0.0
Hardware:	x86 (IA32)
OS:	Windows (All)
Whiteboard:
i915 platform:		i915 features:

Description Tor Lillqvist 2005-09-26 02:30:43 UTC

I think setting lfHeight to the negative of what they currently are set to (in
two places in cairo-win32-font.c) make font sizes match what other applications
use (and thus user expectation) better.

See http://bugzilla.gnome.org/show_bug.cgi?id=309868

Comment 1 Owen Taylor 2005-09-26 04:59:38 UTC

Change sounds right to me ... a negative height means "em height", which is
what is the standard definition of font size. Positive heights mean "cell
height".

Comment 2 Tor Lillqvist 2005-09-26 07:52:21 UTC

Fixed in HEAD.

Comment 3 Carl Worth 2005-09-26 08:59:54 UTC

This also needs to be commit to BRANCH_1_0 in preparation for the upcoming 1.0.2
release, right?

Comment 4 Tor Lillqvist 2005-09-26 09:11:03 UTC

Fixed also in BRANCH_1_0.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.