Bug 4593 - LOGFONT::lfHeight should be set negative to make font correct size
Summary: LOGFONT::lfHeight should be set negative to make font correct size
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: win32 backend (show other bugs)
Version: 1.0.0
Hardware: x86 (IA32) Windows (All)
: high normal
Assignee: Owen Taylor
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-26 02:30 UTC by Tor Lillqvist
Modified: 2005-09-25 16:11 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Tor Lillqvist 2005-09-26 02:30:43 UTC 
I think setting lfHeight to the negative of what they currently are set to (in
two places in cairo-win32-font.c) make font sizes match what other applications
use (and thus user expectation) better.

See http://bugzilla.gnome.org/show_bug.cgi?id=309868
Comment 1 Owen Taylor 2005-09-26 04:59:38 UTC 
Change sounds right to me ... a negative height means "em height", which is
what is the standard definition of font size. Positive heights mean "cell
height".
Comment 2 Tor Lillqvist 2005-09-26 07:52:21 UTC 
Fixed in HEAD.
Comment 3 Carl Worth 2005-09-26 08:59:54 UTC 
This also needs to be commit to BRANCH_1_0 in preparation for the upcoming 1.0.2
release, right?
Comment 4 Tor Lillqvist 2005-09-26 09:11:03 UTC 
Fixed also in BRANCH_1_0.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.