Bug 46385

Summary:	suspicious error mappings in Call
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	olivier.crete
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:	Call
i915 platform:		i915 features:

Description Simon McVittie 2012-02-21 03:40:51 UTC

Some of the code to map Jingle reasons to Tp errors seems rather suspicious:

> + case JINGLE_REASON_GONE:
> + /* This one is only in the media channel, we don't have a
> + * Call reason to match */
> + call_reason = TP_CALL_STATE_CHANGE_REASON_UNKNOWN;
> + break;

Doesn't that mean we should add a Call reason, or at least a detailed D-Bus error string?

> + case JINGLE_REASON_EXPIRED:
> + /* No matching error in our spec */
> + call_reason = TP_CALL_STATE_CHANGE_REASON_UNKNOWN;
> + break;

Ditto

> + case JINGLE_REASON_GENERAL_ERROR:
> + call_reason = TP_CALL_STATE_CHANGE_REASON_SERVICE_ERROR;
> + break;

Is this really the right mapping?

> + case JINGLE_REASON_UNSUPPORTED_TRANSPORTS:
> + call_reason = TP_CALL_STATE_CHANGE_REASON_NETWORK_ERROR;
> + break;

Ditto

> + case JINGLE_REASON_SECURITY_ERROR:
> + call_reason = TP_CALL_STATE_CHANGE_REASON_CONNECTIVITY_ERROR;
> + break;

Ditto

> + case JINGLE_REASON_ALTERNATIVE_SESSION:
> + break;

Is Unknown really the best we can do here?

Comment 1 GitLab Migration User 2019-12-03 19:55:47 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-gabble/issues/212.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.