Bug 46385 - suspicious error mappings in Call
Summary: suspicious error mappings in Call
Status: NEW
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: Call
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 03:40 UTC by Simon McVittie
Modified: 2012-02-21 03:49 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon McVittie 2012-02-21 03:40:51 UTC
Some of the code to map Jingle reasons to Tp errors seems rather suspicious:

> + case JINGLE_REASON_GONE:
> + /* This one is only in the media channel, we don't have a
> + * Call reason to match */
> + call_reason = TP_CALL_STATE_CHANGE_REASON_UNKNOWN;
> + break;

Doesn't that mean we should add a Call reason, or at least a detailed D-Bus error string?

> + case JINGLE_REASON_EXPIRED:
> + /* No matching error in our spec */
> + call_reason = TP_CALL_STATE_CHANGE_REASON_UNKNOWN;
> + break;

Ditto

> + case JINGLE_REASON_GENERAL_ERROR:
> + call_reason = TP_CALL_STATE_CHANGE_REASON_SERVICE_ERROR;
> + break;

Is this really the right mapping?

> + case JINGLE_REASON_UNSUPPORTED_TRANSPORTS:
> + call_reason = TP_CALL_STATE_CHANGE_REASON_NETWORK_ERROR;
> + break;

Ditto

> + case JINGLE_REASON_SECURITY_ERROR:
> + call_reason = TP_CALL_STATE_CHANGE_REASON_CONNECTIVITY_ERROR;
> + break;

Ditto

> + case JINGLE_REASON_ALTERNATIVE_SESSION:
> + break;

Is Unknown really the best we can do here?


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.