| Summary: | Xorg fails to create xorg.conf.new if user builds Xorg with --sysconfdir config option | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Shawn Starr <shawn.starr> |
| Component: | Build/Modular | Assignee: | Xorg Project Team <xorg-team> |
| Status: | RESOLVED NOTABUG | QA Contact: | |
| Severity: | normal | ||
| Priority: | high | CC: | erik.andren |
| Version: | git | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | |||
This is fairly ugly, and it gets even more ugly with the fact a whole parser is needed to find where the configuration file is! Proposal of the following to fix this: 1) Since we're modular now and we're using GNU Auto* we have variables at our disposal: If a user builds Xorg with --prefix=/usr/X11R6 --sysconfdir=/etc/X11 then we should make a new #define XORG_CONFIGPATH and set this to sysconfdir (if set) otherwise, Auto* will assign prefix as /usr/X11R6/etc/. 2) We already have Xorg -config /locaton/and/file/xorg.conf. If the user needs to override the default XORG_CONFIGPATH this would do this. A patch is coming soon to fix this. If no $prefix is set, then XORG_CONFIGPATH would default to /usr/local/etc as defined by $prefix/$sysconfdir (In reply to comment #1) > This is fairly ugly, and it gets even more ugly with the fact a whole parser is > needed to find where the configuration file is! > > Proposal of the following to fix this: > > 1) Since we're modular now and we're using GNU Auto* we have variables at our > disposal: If a user builds Xorg with --prefix=/usr/X11R6 --sysconfdir=/etc/X11 > then we should make a new #define XORG_CONFIGPATH and set this to sysconfdir > (if set) otherwise, Auto* will assign prefix as /usr/X11R6/etc/. > > 2) We already have Xorg -config /locaton/and/file/xorg.conf. If the user needs > to override the default XORG_CONFIGPATH this would do this. > > A patch is coming soon to fix this. README:
*** Make sure you run the symlink.sh script before applying patches
*** These fix Xorg path issues, they will likely break xorgcfg and xorgconfig
tools at the moment.
Apply xorgconfig-fix-1.diff in xserver/xorg directory:
patch < xorgconfig-fix-1.diff -p0
Apply xorgconfig-fix-2.diff in xserver/xorg/include:
patch < xorgconfig-fix-2.diff -p0
Apply xorgconfig-fix-3.diff in xserver/xorg/hw/xfree86/parser:
patch < xorgconfig-fix-3.diff -p0
Apply xorgconfig-fix-4.diff in xserver/xorg/hw/xfree86/common:
patch < xorgconfig-fix-4.diff -p0
Created attachment 3449 [details] [review] Fix Xorg path misbehavour #1 Fix Xorg path misbehavour Created attachment 3450 [details] [review] Fix Xorg path misbehavour #2 Fix Xorg path misbehavour Created attachment 3451 [details] [review] Fix Xorg path misbehavour #3 Fix Xorg path misbehavour Created attachment 3452 [details] [review] Fix Xorg path misbehavour #4 Fix Xorg path misbehavour #3273 - note for me: constify any variables i've changed so we're consistant *** Bug 2505 has been marked as a duplicate of this bug. *** Comment on attachment 3449 [details] [review] Fix Xorg path misbehavour #1 garbage Comment on attachment 3450 [details] [review] Fix Xorg path misbehavour #2 garbage Comment on attachment 3451 [details] [review] Fix Xorg path misbehavour #3 garbage Comment on attachment 3452 [details] [review] Fix Xorg path misbehavour #4 garbage Created attachment 3453 [details] [review] Much cleaner patch to fix this issue - Fix xorg.conf detection with -configure and friends Cleanup the patch, now you don't need to do any of those silly instructions. Comment on attachment 3453 [details] [review] Much cleaner patch to fix this issue - Fix xorg.conf detection with -configure and friends cleanup, add xfree() xorg-config.h.in also needs to be changed. Created attachment 3454 [details] [review] Fix xorg.conf detection with -configure and friends - add xfree() and xorg-config.h.in changes Add memory cleanups and xorg-config.h.in changes. Hold on this... I want 'xc' to freeze first. I also am going to clean it up so we don't rename variables that exist except FX86CONFIGFILE which is a rather dumb name for a path variable which is changing. This isn't closed! Nevermind My project is ended. Does that mean this has been fixed in CVS in some way? Is this commited or not? I think Ajax is going to do this so this will be handled in other ways. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
(==) Log file: "/usr/X11R6/var/log/Xorg.0.log", Time: Fri Sep 30 01:12:49 2005 List of video drivers: s3virge (EE) Unable to locate/open config file: "/root//etc/X11/xorg.conf.new"