Bug 4641 - Xorg fails to create xorg.conf.new if user builds Xorg with --sysconfdir config option
Summary: Xorg fails to create xorg.conf.new if user builds Xorg with --sysconfdir conf...
Status: RESOLVED NOTABUG
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Modular (show other bugs)
Version: git
Hardware: All Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-29 22:26 UTC by Shawn Starr
Modified: 2006-03-13 16:11 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Fix Xorg path misbehavour #1 (1.34 KB, patch)
2005-09-30 21:02 UTC, Shawn Starr
no flags Details | Splinter Review
Fix Xorg path misbehavour #2 (461 bytes, patch)
2005-09-30 21:03 UTC, Shawn Starr
no flags Details | Splinter Review
Fix Xorg path misbehavour #3 (7.79 KB, patch)
2005-09-30 21:03 UTC, Shawn Starr
no flags Details | Splinter Review
Fix Xorg path misbehavour #4 (5.11 KB, patch)
2005-09-30 21:03 UTC, Shawn Starr
no flags Details | Splinter Review
Much cleaner patch to fix this issue - Fix xorg.conf detection with -configure and friends (17.23 KB, patch)
2005-10-01 00:02 UTC, Shawn Starr
no flags Details | Splinter Review
Fix xorg.conf detection with -configure and friends - add xfree() and xorg-config.h.in changes (19.56 KB, patch)
2005-10-01 00:47 UTC, Shawn Starr
no flags Details | Splinter Review

Description Shawn Starr 2005-09-29 22:26:57 UTC
(==) Log file: "/usr/X11R6/var/log/Xorg.0.log", Time: Fri Sep 30 01:12:49 2005 
List of video drivers: 
        s3virge 
(EE) Unable to locate/open config file: "/root//etc/X11/xorg.conf.new"
Comment 1 Shawn Starr 2005-09-29 22:30:24 UTC
This is fairly ugly, and it gets even more ugly with the fact a whole parser is 
needed to find where the configuration file is! 
 
Proposal of the following to fix this: 
 
1) Since we're modular now and we're using GNU Auto* we have variables at our 
disposal: If a user builds Xorg with --prefix=/usr/X11R6 --sysconfdir=/etc/X11 
then we should make a new #define XORG_CONFIGPATH and set this to sysconfdir 
(if set) otherwise, Auto* will assign prefix as /usr/X11R6/etc/. 
 
2) We already have Xorg -config /locaton/and/file/xorg.conf. If the user needs 
to override the default XORG_CONFIGPATH this would do this. 
 
A patch is coming soon to fix this. 
Comment 2 Shawn Starr 2005-09-29 22:40:31 UTC
If no $prefix is set, then XORG_CONFIGPATH would default to /usr/local/etc as 
defined by $prefix/$sysconfdir 
 
(In reply to comment #1) 
> This is fairly ugly, and it gets even more ugly with the fact a whole parser 
is  
> needed to find where the configuration file is!  
>   
> Proposal of the following to fix this:  
>   
> 1) Since we're modular now and we're using GNU Auto* we have variables at our  
> disposal: If a user builds Xorg with --prefix=/usr/X11R6 
--sysconfdir=/etc/X11  
> then we should make a new #define XORG_CONFIGPATH and set this to sysconfdir  
> (if set) otherwise, Auto* will assign prefix as /usr/X11R6/etc/.  
>   
> 2) We already have Xorg -config /locaton/and/file/xorg.conf. If the user 
needs  
> to override the default XORG_CONFIGPATH this would do this.  
>   
> A patch is coming soon to fix this.  
 
 
Comment 3 Shawn Starr 2005-09-30 21:01:29 UTC
README:  
 
*** Make sure you run the symlink.sh script before applying patches 
 
*** These fix Xorg path issues, they will likely break xorgcfg and xorgconfig     
    tools at the moment. 
 
Apply xorgconfig-fix-1.diff in xserver/xorg directory: 
 
patch < xorgconfig-fix-1.diff -p0 
 
Apply xorgconfig-fix-2.diff in xserver/xorg/include: 
 
patch < xorgconfig-fix-2.diff -p0 
 
Apply xorgconfig-fix-3.diff in xserver/xorg/hw/xfree86/parser: 
 
patch < xorgconfig-fix-3.diff -p0 
 
Apply xorgconfig-fix-4.diff in xserver/xorg/hw/xfree86/common: 
 
patch < xorgconfig-fix-4.diff -p0 
 
Comment 4 Shawn Starr 2005-09-30 21:02:46 UTC
Created attachment 3449 [details] [review]
Fix Xorg path misbehavour #1

Fix Xorg path misbehavour
Comment 5 Shawn Starr 2005-09-30 21:03:11 UTC
Created attachment 3450 [details] [review]
Fix Xorg path misbehavour #2

Fix Xorg path misbehavour
Comment 6 Shawn Starr 2005-09-30 21:03:29 UTC
Created attachment 3451 [details] [review]
Fix Xorg path misbehavour #3

Fix Xorg path misbehavour
Comment 7 Shawn Starr 2005-09-30 21:03:50 UTC
Created attachment 3452 [details] [review]
Fix Xorg path misbehavour #4

Fix Xorg path misbehavour
Comment 8 Shawn Starr 2005-09-30 22:31:28 UTC
#3273 - note for me: constify any variables i've changed so we're consistant  
Comment 9 Shawn Starr 2005-09-30 22:53:13 UTC
*** Bug 2505 has been marked as a duplicate of this bug. ***
Comment 10 Shawn Starr 2005-09-30 23:59:50 UTC
Comment on attachment 3449 [details] [review]
Fix Xorg path misbehavour #1

garbage
Comment 11 Shawn Starr 2005-10-01 00:00:14 UTC
Comment on attachment 3450 [details] [review]
Fix Xorg path misbehavour #2

garbage
Comment 12 Shawn Starr 2005-10-01 00:00:30 UTC
Comment on attachment 3451 [details] [review]
Fix Xorg path misbehavour #3

garbage
Comment 13 Shawn Starr 2005-10-01 00:00:46 UTC
Comment on attachment 3452 [details] [review]
Fix Xorg path misbehavour #4

garbage
Comment 14 Shawn Starr 2005-10-01 00:02:20 UTC
Created attachment 3453 [details] [review]
Much cleaner patch to fix this issue - Fix xorg.conf detection with -configure and friends

Cleanup the patch, now you don't need to do any of those silly instructions.
Comment 15 Shawn Starr 2005-10-01 00:46:52 UTC
Comment on attachment 3453 [details] [review]
Much cleaner patch to fix this issue - Fix xorg.conf detection with -configure and friends

cleanup, add xfree() xorg-config.h.in also needs to be changed.
Comment 16 Shawn Starr 2005-10-01 00:47:58 UTC
Created attachment 3454 [details] [review]
Fix xorg.conf detection with -configure and friends - add xfree() and xorg-config.h.in changes

Add memory cleanups and xorg-config.h.in changes.
Comment 17 Shawn Starr 2005-10-03 15:13:53 UTC
Hold on this... I want 'xc' to freeze first. I also am going to clean it up so
we don't rename variables that exist except FX86CONFIGFILE which is a rather
dumb name for a path variable which is changing. 
Comment 18 Shawn Starr 2005-10-03 15:14:13 UTC
This isn't closed!
Comment 19 Shawn Starr 2005-10-31 23:37:17 UTC
Nevermind 
Comment 20 Shawn Starr 2005-10-31 23:37:51 UTC
My project is ended. 
Comment 21 Joshua Baergen 2005-11-21 06:01:27 UTC
Does that mean this has been fixed in CVS in some way?
Comment 22 Erik Andren 2006-03-14 08:24:58 UTC
Is this commited or not?
Comment 23 Shawn Starr 2006-03-14 11:11:51 UTC
I think Ajax is going to do this so this will be handled in other ways.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.