| Summary: | vesa driver does not honor "NoDDC" option (patch attached) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Ian Lepore <freebsd-xorg> | ||||
| Component: | Driver/Vesa | Assignee: | Xorg Project Team <xorg-team> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||
| Severity: | normal | ||||||
| Priority: | medium | CC: | ajax | ||||
| Version: | unspecified | ||||||
| Hardware: | x86 (IA32) | ||||||
| OS: | FreeBSD | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
commit f7876ce62c751c9b28d5750e1d01def877e666fb Author: Ian Lepore <freebsd-xorg@damnhippie.dyndns.org> Date: Wed Jan 31 10:48:09 2018 -0500 Honor Option "NoDDC" correctly Move xf86CollectOptions before the DDC code so it can actually hear us when we ask to disable DDC. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=46541 Signed-off-by: Adam Jackson <ajax@redhat.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 57557 [details] Patch to vesa.c to call xf86CollectOptions() before loading ddc module The vesa driver loads the ddc module and invokes its functions before calling xf86CollectOptions(), so the ddc module never sees the NoDDC option. I have buggy bios on a single-board computer with a builtin LCD panel that claims to support DDC but then locks up trying to access it. Without the attached patch I cannot run X on this board. The patch simply moves the xf86CollectionOptions() call up to a point before the ddc module is loaded and invoked. My inclination would be to call it even earlier, but for reasons I don't understand (and I'm out of time to track down why), the xf86CollectOptions() function segfaults if called before xf86SetDefaultVisual().