Created attachment 57557 [details]
Patch to vesa.c to call xf86CollectOptions() before loading ddc module
The vesa driver loads the ddc module and invokes its functions before calling xf86CollectOptions(), so the ddc module never sees the NoDDC option. I have buggy bios on a single-board computer with a builtin LCD panel that claims to support DDC but then locks up trying to access it. Without the attached patch I cannot run X on this board.
The patch simply moves the xf86CollectionOptions() call up to a point before the ddc module is loaded and invoked. My inclination would be to call it even earlier, but for reasons I don't understand (and I'm out of time to track down why), the xf86CollectOptions() function segfaults if called before xf86SetDefaultVisual().
Author: Ian Lepore <firstname.lastname@example.org>
Date: Wed Jan 31 10:48:09 2018 -0500
Honor Option "NoDDC" correctly
Move xf86CollectOptions before the DDC code so it can actually hear us
when we ask to disable DDC.
Signed-off-by: Adam Jackson <email@example.com>