Bug 46971

Summary:	[next] regression in tests/dbus/self-presence
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-glib	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	jonny.lamb
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://cgit.freedesktop.org/~smcv/telepathy-glib/log?h=next-regression-46971
Whiteboard:	review+
i915 platform:		i915 features:
Attachments:	tests: wait for CONNECTED feature where we used to

Description Simon McVittie 2012-03-05 04:23:07 UTC

Created attachment 58020 [details] [review]
tests: wait for CONNECTED feature where we used to

Commit 2be1aca4e3 caused an intermittent regression in
tests/dbus/self-presence.c. The example Connection we use only makes
its statuses available when the connection has connected, simulating a
CM like Gabble where available statuses are discovered during connection.

Previously, we used tp_connection_run_until_ready() which effectively
waits for the CONNECTED feature; in that commit, I switched to using
tp_tests_proxy_run_until_prepared() which does not, unless you ask for
it. As a result, there was a race between Get(..., "Statuses") and the
connecting process, leading to intermittent (1/10?) test failures.

This commit updates all tests touched by 2be1aca4e3, except for
invalidated-while-invoking-signals.c which doesn't actually need to
reach the CONNECTED status.

Comment 1 Jonny Lamb 2012-03-05 15:14:02 UTC

Comment on attachment 58020 [details] [review]
tests: wait for CONNECTED feature where we used to

Review of attachment 58020 [details] [review]:
-----------------------------------------------------------------

Gogogoogo.

Comment 2 Simon McVittie 2012-03-06 02:58:28 UTC

Thanks, gonegonegone.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.