Created attachment 58020 [details] [review] tests: wait for CONNECTED feature where we used to Commit 2be1aca4e3 caused an intermittent regression in tests/dbus/self-presence.c. The example Connection we use only makes its statuses available when the connection has connected, simulating a CM like Gabble where available statuses are discovered during connection. Previously, we used tp_connection_run_until_ready() which effectively waits for the CONNECTED feature; in that commit, I switched to using tp_tests_proxy_run_until_prepared() which does not, unless you ask for it. As a result, there was a race between Get(..., "Statuses") and the connecting process, leading to intermittent (1/10?) test failures. This commit updates all tests touched by 2be1aca4e3, except for invalidated-while-invoking-signals.c which doesn't actually need to reach the CONNECTED status.
Comment on attachment 58020 [details] [review] tests: wait for CONNECTED feature where we used to Review of attachment 58020 [details] [review]: ----------------------------------------------------------------- Gogogoogo.
Thanks, gonegonegone.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.