Bug 47045

Summary: Fix incorrect argument to is_excluded()
Product: accountsservice Reporter: Bastien Nocera <bugzilla>
Component: generalAssignee: Matthias Clasen <mclasen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: rstrode
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Fix incorrect argument to is_excluded()

Description Bastien Nocera 2012-03-07 03:27:25 UTC
We're checking whether a user in the wtmp database should be excluded, but we use the minimal UID instead of the entry's UID to check for addition.
Comment 1 Bastien Nocera 2012-03-07 03:27:43 UTC
Created attachment 58110 [details] [review]
Fix incorrect argument to is_excluded()

We're checking whether a user in the wtmp database should
be excluded, but we use the minimal UID instead of the entry's
UID to check for addition.
Comment 2 Ray Strode [halfline] 2012-03-15 16:34:56 UTC
Comment on attachment 58110 [details] [review]
Fix incorrect argument to is_excluded()

Review of attachment 58110 [details] [review]:
-----------------------------------------------------------------

::: src/daemon.c
@@ +198,4 @@
>  
>                  if (daemon_local_user_is_excluded (daemon,
>                                                     wtmp_entry->ut_user,
> +                                                   wtmp_entry->ut_pid)) {

that says pid not uid.  You'll probably have to do getpwnam(wtmp_entry->ut_user)
Comment 3 Ray Strode [halfline] 2012-03-26 12:51:39 UTC
This got fixed by bug 44408

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.