Bug 47045 - Fix incorrect argument to is_excluded()
Summary: Fix incorrect argument to is_excluded()
Status: RESOLVED FIXED
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-07 03:27 UTC by Bastien Nocera
Modified: 2012-03-26 12:51 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Fix incorrect argument to is_excluded() (1.06 KB, patch)
2012-03-07 03:27 UTC, Bastien Nocera
Details | Splinter Review

Description Bastien Nocera 2012-03-07 03:27:25 UTC
We're checking whether a user in the wtmp database should be excluded, but we use the minimal UID instead of the entry's UID to check for addition.
Comment 1 Bastien Nocera 2012-03-07 03:27:43 UTC
Created attachment 58110 [details] [review]
Fix incorrect argument to is_excluded()

We're checking whether a user in the wtmp database should
be excluded, but we use the minimal UID instead of the entry's
UID to check for addition.
Comment 2 Ray Strode [halfline] 2012-03-15 16:34:56 UTC
Comment on attachment 58110 [details] [review]
Fix incorrect argument to is_excluded()

Review of attachment 58110 [details] [review]:
-----------------------------------------------------------------

::: src/daemon.c
@@ +198,4 @@
>  
>                  if (daemon_local_user_is_excluded (daemon,
>                                                     wtmp_entry->ut_user,
> +                                                   wtmp_entry->ut_pid)) {

that says pid not uid.  You'll probably have to do getpwnam(wtmp_entry->ut_user)
Comment 3 Ray Strode [halfline] 2012-03-26 12:51:39 UTC
This got fixed by bug 44408


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.