| Summary: | Remove deprecated method g_thread_init | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Alvaro Soliverez <alvaro.soliverez> |
| Component: | salut | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.com/git/user/asoliver/telepathy-salut/log/?h=thread-init | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
|
Description
Alvaro Soliverez
2012-03-19 17:45:10 UTC
g_thread_init() is still needed in GLib 2.30 and older, but since GLib 2.24, g_type_init() implies g_thread_init (NULL). Salut already calls g_type_init(), and depends on GLib 2.24, so it doesn't need to initialize threads explicitly. If that wasn't true, this change wouldn't be safe. It's pretty subtle, so please amend the commit message to justify why it's OK (e.g. copy the previous paragraph sentence). After that, this is OK to commit. Commit message amended Ship it. (Or ping me or another committer, if you can't...) commit bcd37858f4b36c3123919d80200f77deeb0b8db3 Author: Alvaro Soliverez <alvaro.soliverez@collabora.co.uk> Date: Mon Mar 19 21:01:12 2012 -0300 g_thread_init() is deprecated but still needed in GLib 2.30 and older. Salut calls g_type_init(), which implies g_thread_init(NULL), and depends on GLib 2.24, so it doesn't need to initialize threads explicitely. Therefore, it is safe to remove the call in this case |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.