Bug 47540 - Remove deprecated method g_thread_init
Summary: Remove deprecated method g_thread_init
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/as...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-03-19 17:45 UTC by Alvaro Soliverez
Modified: 2012-03-20 05:32 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Alvaro Soliverez 2012-03-19 17:45:10 UTC
This method is deprecated and no longer needed. It's preventing the project from building correctly in the Windows platform
Comment 1 Simon McVittie 2012-03-20 04:04:00 UTC
g_thread_init() is still needed in GLib 2.30 and older, but since GLib 2.24, g_type_init() implies g_thread_init (NULL). Salut already calls g_type_init(), and depends on GLib 2.24, so it doesn't need to initialize threads explicitly.

If that wasn't true, this change wouldn't be safe. It's pretty subtle, so please amend the commit message to justify why it's OK (e.g. copy the previous paragraph sentence). After that, this is OK to commit.
Comment 2 Alvaro Soliverez 2012-03-20 04:54:00 UTC
Commit message amended
Comment 3 Simon McVittie 2012-03-20 05:14:47 UTC
Ship it. (Or ping me or another committer, if you can't...)
Comment 4 Alvaro Soliverez 2012-03-20 05:32:37 UTC
commit bcd37858f4b36c3123919d80200f77deeb0b8db3
Author: Alvaro Soliverez <alvaro.soliverez@collabora.co.uk>
Date:   Mon Mar 19 21:01:12 2012 -0300

    g_thread_init() is deprecated but still needed in GLib 2.30 and older.
    Salut calls g_type_init(), which implies g_thread_init(NULL), and
    depends on GLib 2.24, so it doesn't need to initialize threads
    explicitely. Therefore, it is safe to remove the call in this case


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.