| Summary: | --enable/--disable flags to control polkit dependency | ||
|---|---|---|---|
| Product: | ConsoleKit | Reporter: | Samuli Suominen <ssuominen> |
| Component: | Daemon | Assignee: | william.jon.mccann |
| Status: | NEW --- | QA Contact: | |
| Severity: | minor | ||
| Priority: | medium | CC: | freedesktop-bugs, lennart, rstrode |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Default is "auto" so current behavior is kept.
Try to cleanup previous patch, use AS_HELP_STRING and so forth --enable/--disable-polkit switch which is by default enabled, like it is now --enable/--disable-polḱit Same as prev. but with different output for ./configure result? |
||
|
Description
Samuli Suominen
2012-03-20 07:54:08 UTC
Looks good in general. A few comments: - Please use AS_HELP_STRING - have_polkit is unset if you use --disable-polkit, this looks bad in the configure summary - Please use @<:@default=auto@:>@ so the --help output is more consistent - It would be great if you could add a proper patch header, so I can directly apply it via git am. Created attachment 59256 [details] [review] Try to cleanup previous patch, use AS_HELP_STRING and so forth (In reply to comment #1) > Looks good in general. > A few comments: > - Please use AS_HELP_STRING > - have_polkit is unset if you use --disable-polkit, this looks bad in the > configure summary > - Please use @<:@default=auto@:>@ so the --help output is more consistent These should now be covered with the new patch. > - It would be great if you could add a proper patch header, so I can directly > apply it via git am. I'm not perfect with git, I hope you can cope with the attached patch. :-/ Created attachment 59265 [details] [review] --enable/--disable-polkit switch which is by default enabled, like it is now This should be properly formatted as requested. Created attachment 59266 [details] [review] --enable/--disable-polḱit Hmm. Dropped the 'auto' in last patch, wasn't good idea. This should be it! :P Created attachment 59268 [details] [review] Same as prev. but with different output for ./configure result? Alternative one using have_polkit in the ./configure output to always get yes or no instead of auto. Not sure if this is desired, but at least one of the two patches should be acceptable then :P |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.