Bug 47587 - --enable/--disable flags to control polkit dependency
Summary: --enable/--disable flags to control polkit dependency
Status: NEW
Alias: None
Product: ConsoleKit
Classification: Unclassified
Component: Daemon (show other bugs)
Version: unspecified
Hardware: All All
: medium minor
Assignee: william.jon.mccann
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 07:54 UTC by Samuli Suominen
Modified: 2012-03-30 04:02 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Default is "auto" so current behavior is kept. (841 bytes, patch)
2012-03-20 07:54 UTC, Samuli Suominen
Details | Splinter Review
Try to cleanup previous patch, use AS_HELP_STRING and so forth (1.54 KB, patch)
2012-03-30 00:08 UTC, Samuli Suominen
Details | Splinter Review
--enable/--disable-polkit switch which is by default enabled, like it is now (2.02 KB, patch)
2012-03-30 03:16 UTC, Samuli Suominen
Details | Splinter Review
--enable/--disable-polḱit (2.02 KB, patch)
2012-03-30 03:20 UTC, Samuli Suominen
Details | Splinter Review
Same as prev. but with different output for ./configure result? (1.56 KB, patch)
2012-03-30 04:02 UTC, Samuli Suominen
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen 2012-03-20 07:54:08 UTC
Created attachment 58756 [details] [review]
Default is "auto" so current behavior is kept.

A simple patch created by "Gilles Dartiguelongue <eva@gentoo.org>" for controlling the polkit dependency.

We have been carrying this since version 0.4.0 in Gentoo's Portage and it still applied cleanly on 0.4.5.
Comment 1 Michael Biebl 2012-03-27 18:58:34 UTC
Looks good in general.
A few comments:
- Please use AS_HELP_STRING
- have_polkit is unset if you use --disable-polkit, this looks bad in the configure summary
- Please use @<:@default=auto@:>@ so the --help output is more consistent
- It would be great if you could add a proper patch header, so I can directly apply it via git am.
Comment 2 Samuli Suominen 2012-03-30 00:08:21 UTC
Created attachment 59256 [details] [review]
Try to cleanup previous patch, use AS_HELP_STRING and so forth
Comment 3 Samuli Suominen 2012-03-30 00:09:51 UTC
(In reply to comment #1)
> Looks good in general.
> A few comments:
> - Please use AS_HELP_STRING
> - have_polkit is unset if you use --disable-polkit, this looks bad in the
> configure summary
> - Please use @<:@default=auto@:>@ so the --help output is more consistent

These should now be covered with the new patch.

> - It would be great if you could add a proper patch header, so I can directly
> apply it via git am.

I'm not perfect with git, I hope you can cope with the attached patch. :-/
Comment 4 Samuli Suominen 2012-03-30 03:16:10 UTC
Created attachment 59265 [details] [review]
--enable/--disable-polkit switch which is by default enabled, like it is now

This should be properly formatted as requested.
Comment 5 Samuli Suominen 2012-03-30 03:20:50 UTC
Created attachment 59266 [details] [review]
--enable/--disable-polḱit

Hmm. Dropped the 'auto' in last patch, wasn't good idea. This should be it! :P
Comment 6 Samuli Suominen 2012-03-30 04:02:04 UTC
Created attachment 59268 [details] [review]
Same as prev. but with different output for ./configure result?

Alternative one using have_polkit in the ./configure output to always get yes or no instead of auto. 
Not sure if this is desired, but at least one of the two patches should be acceptable then :P


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.