Created attachment 58756 [details] [review]
Default is "auto" so current behavior is kept.
A simple patch created by "Gilles Dartiguelongue <firstname.lastname@example.org>" for controlling the polkit dependency.
We have been carrying this since version 0.4.0 in Gentoo's Portage and it still applied cleanly on 0.4.5.
Looks good in general.
A few comments:
- Please use AS_HELP_STRING
- have_polkit is unset if you use --disable-polkit, this looks bad in the configure summary
- Please use @<:@default=auto@:>@ so the --help output is more consistent
- It would be great if you could add a proper patch header, so I can directly apply it via git am.
Created attachment 59256 [details] [review]
Try to cleanup previous patch, use AS_HELP_STRING and so forth
(In reply to comment #1)
> Looks good in general.
> A few comments:
> - Please use AS_HELP_STRING
> - have_polkit is unset if you use --disable-polkit, this looks bad in the
> configure summary
> - Please use @<:@default=auto@:>@ so the --help output is more consistent
These should now be covered with the new patch.
> - It would be great if you could add a proper patch header, so I can directly
> apply it via git am.
I'm not perfect with git, I hope you can cope with the attached patch. :-/
Created attachment 59265 [details] [review]
--enable/--disable-polkit switch which is by default enabled, like it is now
This should be properly formatted as requested.
Created attachment 59266 [details] [review]
Hmm. Dropped the 'auto' in last patch, wasn't good idea. This should be it! :P
Created attachment 59268 [details] [review]
Same as prev. but with different output for ./configure result?
Alternative one using have_polkit in the ./configure output to always get yes or no instead of auto.
Not sure if this is desired, but at least one of the two patches should be acceptable then :P