Bug 51037

Summary:	Flag local users and treat them differently
Product:	accountsservice	Reporter:	Stef Walter <stefw>
Component:	general	Assignee:	Matthias Clasen <mclasen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	rstrode
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	50770
Bug Blocks:	53443
Attachments:	Add User.Local dbus property Don't use userdel for deletion of remote users Rename user_local_xxxx() to user_xxxx() Add User.Local dbus property

Description Stef Walter 2012-06-13 07:07:15 UTC

Treat local and remote users differently. We try to use
/etc/passwd as a heuristic for whether a user is 'local'
or 'remote'.

Also don't run userdel for remote users.

Should we be deleting the user's home directory manually
for remote users if remove_files is set?

Comment 1 Stef Walter 2012-06-13 07:07:18 UTC

Created attachment 62964 [details] [review]
Add User.Local dbus property

This property describes whether the user account is local to the machine
or not, and thus can be managed with usermod, userdel and so on.

We currently implement this as a heuristic. If it's found in /etc/passwd
then we treat it as 'local'

Comment 2 Stef Walter 2012-06-13 07:07:21 UTC

Created attachment 62965 [details] [review]
Don't use userdel for deletion of remote users

Comment 3 Stef Walter 2012-08-14 15:45:43 UTC

Comment on attachment 62965 [details] [review]
Don't use userdel for deletion of remote users

Moving this patch to another bug.

Comment 4 Stef Walter 2012-08-14 15:47:46 UTC

Created attachment 65555 [details] [review]
Rename user_local_xxxx() to user_xxxx()

    Rename user_local_xxxx() to user_xxxx()
    
     * Since User* applies to remote users too, and the 'local'
       terminology can be confusing.

Comment 5 Stef Walter 2012-08-14 15:48:42 UTC

Created attachment 65556 [details] [review]
Add User.Local dbus property

Updated the patch so it works correctly in user cases

Comment 6 Ray Strode [halfline] 2012-08-16 18:55:09 UTC

Comment on attachment 65555 [details] [review]
Rename user_local_xxxx() to user_xxxx()

Review of attachment 65555 [details] [review]:
-----------------------------------------------------------------

seems fine, though now daemon is inconsistent.  Pushed.

Comment 7 Ray Strode [halfline] 2012-08-16 19:03:16 UTC

Comment on attachment 65556 [details] [review]
Add User.Local dbus property

Review of attachment 65556 [details] [review]:
-----------------------------------------------------------------

pushed.

Comment 8 Matthias Clasen 2012-09-22 00:32:05 UTC

I think all is done here.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.