Bug 5138

Summary:

Xming LookupIDByType casts and NULL pointer returns

Product:

xorg

Reporter:

Colin Harrison <colin.harrison>

Component:

Server/DDX/Xwin

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

high

Version:

git

Hardware:

x86 (IA32)

OS:

Windows (All)

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
Fix for this problem	none

Description Colin Harrison 2005-11-24 01:53:32 UTC

A missing NULL pointer test after a return from LookupIDByType() has caused an 
occasional crash in Xming.
A NULL return test should always be made on return from LookupIDByType() before 
the pointer is used!
The return from LookupIDByType() should also be casted for safety.

Comment 1 Colin Harrison 2005-11-24 01:54:19 UTC

Created attachment 3886 [details] [review]
Fix for this problem

Comment 2 Alan Hourihane 2006-03-03 20:43:55 UTC

Applied. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.