Bug 5138 - Xming LookupIDByType casts and NULL pointer returns
Summary: Xming LookupIDByType casts and NULL pointer returns
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/DDX/Xwin (show other bugs)
Version: git
Hardware: x86 (IA32) Windows (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-24 01:53 UTC by Colin Harrison
Modified: 2006-03-03 01:43 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Fix for this problem (1.40 KB, patch)
2005-11-24 01:54 UTC, Colin Harrison 		no flags Details | Splinter Review
View All

Description Colin Harrison 2005-11-24 01:53:32 UTC 
A missing NULL pointer test after a return from LookupIDByType() has caused an 
occasional crash in Xming.
A NULL return test should always be made on return from LookupIDByType() before 
the pointer is used!
The return from LookupIDByType() should also be casted for safety.
Comment 1 Colin Harrison 2005-11-24 01:54:19 UTC 
Created attachment 3886 [details] [review]
Fix for this problem
Comment 2 Alan Hourihane 2006-03-03 20:43:55 UTC 
Applied. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.