Bug 52289

Summary:

Colors aqua, fuchsia, lime, olive, silver, teal missing from rgb.txt

Product:

xorg

Reporter:

7.2k9a4Y3W5c

Component:

Server/General

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

CC:

daphnediane

Version:

unspecified

Keywords:

patch

Hardware:

x86-64 (AMD64)

OS:

Linux (All)

See Also:

https://bugs.freedesktop.org/show_bug.cgi?id=80371

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
patch file	none
Regenerated os/oscolor.c based on newest version of rgb.txt	none
Perl script used to generate the oscolor.c patch	none

Description 7.2k9a4Y3W5c 2012-07-20 05:51:39 UTC

The following colors are missing from rgb.txt:
aqua,fuchsia,lime,olive,silver,teal
These are listed as as "Basic color keywords" and/or "Extended color keyword" by w3.org. 

http://www.w3.org/TR/css3-color/#html4

http://www.w3.org/TR/css3-color/#svg-color

This is affecting several other packages including: Pango, gdk-pixbuf and gtk+3 with it's new CSS capabilities. xpm-color-table.h in gdk-pixbuf and pango-color-table.h in Pango are generated by the script gen-color-table.pl from rgb.txt

Comment 1 7.2k9a4Y3W5c 2012-07-21 02:06:50 UTC

Created attachment 64473 [details] [review]
patch file

Comment 2 Daphne Pfister 2014-07-07 02:06:34 UTC

Created attachment 102335 [details] [review]
Regenerated os/oscolor.c based on newest version of rgb.txt

Updates os/oscolor.c to match the changes to app/rgb from bug 80371

Comment 3 Daphne Pfister 2014-07-07 02:08:41 UTC

Created attachment 102336 [details]
Perl script used to generate the oscolor.c patch

Perl script that I used to update oscolor.c in case it is useful.

Comment 4 Daphne Pfister 2014-07-07 06:27:02 UTC

(In reply to comment #3)
> Created attachment 102336 [details]
> Perl script used to generate the oscolor.c patch
> 
> Perl script that I used to update oscolor.c in case it is useful.

I forgot to add license to the perl script since I just did it as throw away as I don't imagine it is needed that often. But if turns out to be worth keeping canonical license is fine.

Comment 5 Alan Coopersmith 2018-06-13 18:08:45 UTC

These fixes were already applied - we just forgot to close the bug:

https://cgit.freedesktop.org/xorg/app/rgb/commit/?id=ee2c453a748af6fbd0b31569b3b240517b9320f3

https://cgit.freedesktop.org/xorg/xserver/commit/?id=4599a4492ca6a1c87cd9c537c54fbda11f13c15c

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.