Bug 80371 - App/rgb should include rebeccapurple
Summary: App/rgb should include rebeccapurple
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-23 00:32 UTC by Daphne Pfister
Modified: 2014-07-07 02:10 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Adds the color (627 bytes, patch)
2014-06-23 00:36 UTC, Daphne Pfister
no flags Details | Splinter Review
Add missing CSS color terms (1.44 KB, patch)
2014-06-23 05:07 UTC, Daphne Pfister
no flags Details | Splinter Review
Add aliases for conflicting color terms (1.82 KB, patch)
2014-06-23 05:09 UTC, Daphne Pfister
no flags Details | Splinter Review

Description Daphne Pfister 2014-06-23 00:32:59 UTC
Recently CSS added the rebeccapurple ( #663399 ) to their color list which is mostly based on the X11 color list. See http://lists.w3.org/Archives/Public/www-style/2014Jun/0312.html. Seems like it might make sense to include this color in rgb.txt as well to minimize the difference between the two color lists.
Comment 1 Daphne Pfister 2014-06-23 00:36:16 UTC
Created attachment 101547 [details] [review]
Adds the color
Comment 2 Daphne Pfister 2014-06-23 05:07:20 UTC
Created attachment 101551 [details] [review]
Add missing CSS color terms

Update rgb.txt to include missing CSS color names. Adding aqua, lime, fuchsia, crimson, indigo, olive, rebecca purple, silver and teal.
Comment 3 Daphne Pfister 2014-06-23 05:09:33 UTC
Created attachment 101552 [details] [review]
Add aliases for conflicting color terms

This patch adds alias for the 4 colors that differ between X11 and HTML/CSS colors. Using a prefix of X11 for the original X11 colors, and a prefix of Web for the HTML/CSS colors.
Comment 4 Alan Coopersmith 2014-07-06 16:19:14 UTC
Thanks for the patches - I've pushed them to git master of the rgb module:

To ssh://git.freedesktop.org/git/xorg/app/rgb
   107c0c2..ca05c39  master -> master

However, X clients who query colors from the X server via the X protocol will
not see them until the table built into the X server sources is regenerated.
Right now, the X server is only taking critical bug fixes in preperation for
the xorg-server-1.16 release - once that's done, the window will reopen for
enhancements and less critical bug fixes, and we'll be able to update the
color tables then.
Comment 5 Daphne Pfister 2014-07-07 02:10:46 UTC
(In reply to comment #4)
> Thanks for the patches - I've pushed them to git master of the rgb module:
> 
> To ssh://git.freedesktop.org/git/xorg/app/rgb
>    107c0c2..ca05c39  master -> master
> 
> However, X clients who query colors from the X server via the X protocol will
> not see them until the table built into the X server sources is regenerated.
> Right now, the X server is only taking critical bug fixes in preperation for
> the xorg-server-1.16 release - once that's done, the window will reopen for
> enhancements and less critical bug fixes, and we'll be able to update the
> color tables then.

Thanks, I added an updated patch to bug 52289 to handle the server side, for once 1.16 has been released.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.