Bug 53142

Summary:	Don't use GDK_THREADS_ENTER/LEAVE
Product:	Spice	Reporter:	Matthias Clasen <mclasen>
Component:	spice-gtk	Assignee:	Spice Bug List <spice-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch

Description Matthias Clasen 2012-08-05 15:21:08 UTC

These macros have been deprecated. The quick fix for now is to just use the functions gdk_threads_enter/leave instead. They are deprecated as well, but deprecated functions don't cause the build to fail (unless you use -Werror).

Comment 1 Matthias Clasen 2012-08-05 15:37:49 UTC

Created attachment 65143 [details] [review]
patch

Comment 2 Marc-Andre Lureau 2012-08-05 15:55:36 UTC

thanks, applied

Any idea what will be the fix? iirc, without that enter/leave, it will hang. And after looking at gtk/gtkclipboard.c, I copied that without digging the real problem further. It's a bit ugly that we have to call g_main_loop_run()..

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.