Bug 53142 - Don't use GDK_THREADS_ENTER/LEAVE
Summary: Don't use GDK_THREADS_ENTER/LEAVE
Status: RESOLVED FIXED
Alias: None
Product: Spice
Classification: Unclassified
Component: spice-gtk (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Spice Bug List
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-05 15:21 UTC by Matthias Clasen
Modified: 2012-08-05 15:55 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch (617 bytes, patch)
2012-08-05 15:37 UTC, Matthias Clasen
Details | Splinter Review

Description Matthias Clasen 2012-08-05 15:21:08 UTC
These macros have been deprecated. The quick fix for now is to just use the functions gdk_threads_enter/leave instead. They are deprecated as well, but deprecated functions don't cause the build to fail (unless you use -Werror).
Comment 1 Matthias Clasen 2012-08-05 15:37:49 UTC
Created attachment 65143 [details] [review]
patch
Comment 2 Marc-Andre Lureau 2012-08-05 15:55:36 UTC
thanks, applied

Any idea what will be the fix? iirc, without that enter/leave, it will hang. And after looking at gtk/gtkclipboard.c, I copied that without digging the real problem further. It's a bit ugly that we have to call g_main_loop_run()..


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.