Bug 53201

Summary:	tp_account_dup_storage_identifier_variant: don't warn if storage_identifier is NULL
Product:	Telepathy	Reporter:	Guillaume Desmottes <guillaume.desmottes>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=storage-53201
Whiteboard:	review+
i915 platform:		i915 features:

Description Guillaume Desmottes 2012-08-07 08:07:29 UTC

Calling tp_account_dup_storage_identifier_variant() on an account having no external storage identifier raises these warnings:


** (process:940): CRITICAL **: dbus_g_value_build_g_variant: assertion `G_IS_VALUE (value)' failed

(process:940): GLib-CRITICAL **: g_variant_ref_sink: assertion `value != NULL' failed

Comment 1 Guillaume Desmottes 2012-08-07 08:10:32 UTC

http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=storage-53201

Comment 2 Jonny Lamb 2012-08-08 08:45:50 UTC

I wonder if people will check the return value of this function for anything which isn't a GVariant?

The patch looks fine.

Comment 3 Guillaume Desmottes 2012-08-08 09:00:29 UTC

Merged to master for 0.19.7 and 0.18 for 0.18.3

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.