Bug 53201 - tp_account_dup_storage_identifier_variant: don't warn if storage_identifier is NULL
Summary: tp_account_dup_storage_identifier_variant: don't warn if storage_identifier i...
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/ca...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-08-07 08:07 UTC by Guillaume Desmottes
Modified: 2012-08-08 09:00 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Guillaume Desmottes 2012-08-07 08:07:29 UTC 
Calling tp_account_dup_storage_identifier_variant() on an account having no external storage identifier raises these warnings:


** (process:940): CRITICAL **: dbus_g_value_build_g_variant: assertion `G_IS_VALUE (value)' failed

(process:940): GLib-CRITICAL **: g_variant_ref_sink: assertion `value != NULL' failed
Comment 2 Jonny Lamb 2012-08-08 08:45:50 UTC 
I wonder if people will check the return value of this function for anything which isn't a GVariant?

The patch looks fine.
Comment 3 Guillaume Desmottes 2012-08-08 09:00:29 UTC 
Merged to master for 0.19.7 and 0.18 for 0.18.3

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.