| Summary: | introspect util.[ch] | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | tp-glib | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | CC: | xclaesse |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 54544 | ||
| Attachments: |
Introspect util.[ch]
the resulting changes to the .gir |
||
|
Description
Simon McVittie
2012-09-05 10:26:02 UTC
Created attachment 66665 [details] [review] Introspect util.[ch] Most of it is useless in non-C languages, so we (skip) it. However, tp_simple_async_report_success_in_idle(), tp_utf8_make_valid(), tp_escape_as_identifier() and the user-action-time functions all seem like useful things to have. The tp_g_value_slice_new() family confuses g-ir-scanner (which goes looking for a TpGValueSlice type), but they're all (skip)'d anyway, so #ifdef them out. Created attachment 66666 [details]
the resulting changes to the .gir
I would split it to util.h and util-introspectable.h then. (In reply to comment #3) > I would split it to util.h and util-introspectable.h then. Well, if we want to got bug #54544's way, then +1 :-) (In reply to comment #4) > Well, if we want to got bug #54544's way, then +1 :-) I think we do. Unintrospectable things should be the special case, not the default. Fixed in git for 0.19.9 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.