Bug 54543 - introspect util.[ch]
Summary: introspect util.[ch]
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: 54544
  Show dependency tree / graph
 
Reported: 2012-09-05 10:26 UTC by Simon McVittie
Modified: 2012-09-07 16:06 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Introspect util.[ch] (12.65 KB, patch)
2012-09-05 10:26 UTC, Simon McVittie 		Details | Splinter Review
the resulting changes to the .gir (32.10 KB, text/plain)
2012-09-05 10:31 UTC, Simon McVittie 		Details
View All

Description Simon McVittie 2012-09-05 10:26:02 UTC 
util.[ch] is mostly useless to non-C languages, but there are some useful functions in there, notably tp_user_action_time_from_x11() which can be used to work around the unintrospectability of TP_USER_ACTION_TIME_CURRENT_TIME (which is a g-i bug, <https://bugzilla.gnome.org/show_bug.cgi?id=639206>).
Comment 1 Simon McVittie 2012-09-05 10:26:53 UTC 
Created attachment 66665 [details] [review]
Introspect util.[ch]

Most of it is useless in non-C languages, so we (skip) it. However,
tp_simple_async_report_success_in_idle(), tp_utf8_make_valid(),
tp_escape_as_identifier() and the user-action-time functions all
seem like useful things to have.

The tp_g_value_slice_new() family confuses g-ir-scanner (which goes
looking for a TpGValueSlice type), but they're all (skip)'d anyway,
so #ifdef them out.
Comment 2 Simon McVittie 2012-09-05 10:31:24 UTC 
Created attachment 66666 [details]
the resulting changes to the .gir
Comment 3 Xavier Claessens 2012-09-05 10:39:29 UTC 
I would split it to util.h and util-introspectable.h then.
Comment 4 Xavier Claessens 2012-09-05 10:52:52 UTC 
(In reply to comment #3)
> I would split it to util.h and util-introspectable.h then.

Well, if we want to got bug #54544's way, then +1 :-)
Comment 5 Simon McVittie 2012-09-07 16:06:47 UTC 
(In reply to comment #4)
> Well, if we want to got bug #54544's way, then +1 :-)

I think we do. Unintrospectable things should be the special case, not the default.

Fixed in git for 0.19.9

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.