| Summary: | assorted cleanup in MC | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | mission-control | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | minor | ||
| Priority: | medium | CC: | xclaesse |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
McdAccountManager: move initialization from init to constructed
McdAccountManager: remove useless virtual method McdMaster: remove unused variable left over from old-style plugins mcd-dbusprop: remove support for filtering property setting through an ACL mcd_service_new: use tp_dbus_daemon_dup() Use G_VALUE_INIT instead of { 0 } Be single-include-compliant when generating service bindings Don't generate code for Account.I.Addressing, use telepathy-glib's |
||
|
Description
Simon McVittie
2012-09-07 10:31:18 UTC
Created attachment 66773 [details] [review] McdAccountManager: move initialization from init to constructed This lets us use the construct properties, and in particular the TpDBusDaemon, which means we can make it a construct-time property on McdStorage. Created attachment 66774 [details] [review] McdAccountManager: remove useless virtual method We no longer allow McdAccountManager or McdAccount to be subclassed. Created attachment 66775 [details] [review] McdMaster: remove unused variable left over from old-style plugins Created attachment 66776 [details] [review] mcd-dbusprop: remove support for filtering property setting through an ACL This provided an asynchronous API for getting and setting properties, which nothing actually calls into, and nothing in MC supports setting properties asynchronously anyway. Into the bin it goes! Created attachment 66777 [details] [review] mcd_service_new: use tp_dbus_daemon_dup() Created attachment 66778 [details] [review] Use G_VALUE_INIT instead of { 0 } We already depend on GLib 2.30, which is new enough. Created attachment 66779 [details] [review] Be single-include-compliant when generating service bindings Created attachment 66780 [details] [review] Don't generate code for Account.I.Addressing, use telepathy-glib's +1 to all. Awesome :) Fixed in git for 5.13.2 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.