Bug 54633 - assorted cleanup in MC
Summary: assorted cleanup in MC
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: unspecified
Hardware: Other All
: medium minor
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-09-07 10:31 UTC by Simon McVittie
Modified: 2012-09-07 15:24 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
McdAccountManager: move initialization from init to constructed (3.83 KB, patch)
2012-09-07 10:31 UTC, Simon McVittie
Details | Splinter Review
McdAccountManager: remove useless virtual method (3.60 KB, patch)
2012-09-07 10:32 UTC, Simon McVittie
Details | Splinter Review
McdMaster: remove unused variable left over from old-style plugins (688 bytes, patch)
2012-09-07 10:32 UTC, Simon McVittie
Details | Splinter Review
mcd-dbusprop: remove support for filtering property setting through an ACL (6.70 KB, patch)
2012-09-07 10:32 UTC, Simon McVittie
Details | Splinter Review
mcd_service_new: use tp_dbus_daemon_dup() (1.10 KB, patch)
2012-09-07 10:32 UTC, Simon McVittie
Details | Splinter Review
Use G_VALUE_INIT instead of { 0 } (15.47 KB, patch)
2012-09-07 10:33 UTC, Simon McVittie
Details | Splinter Review
Be single-include-compliant when generating service bindings (936 bytes, patch)
2012-09-07 10:33 UTC, Simon McVittie
Details | Splinter Review
Don't generate code for Account.I.Addressing, use telepathy-glib's (9.97 KB, patch)
2012-09-07 10:33 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2012-09-07 10:31:18 UTC
Here are fixes for various minor things I spotted while working on MC.
Comment 1 Simon McVittie 2012-09-07 10:31:51 UTC
Created attachment 66773 [details] [review]
McdAccountManager: move initialization from init to  constructed

This lets us use the construct properties, and in particular the
TpDBusDaemon, which means we can make it a construct-time property
on McdStorage.
Comment 2 Simon McVittie 2012-09-07 10:32:06 UTC
Created attachment 66774 [details] [review]
McdAccountManager: remove useless virtual method

We no longer allow McdAccountManager or McdAccount to be subclassed.
Comment 3 Simon McVittie 2012-09-07 10:32:19 UTC
Created attachment 66775 [details] [review]
McdMaster: remove unused variable left over from   old-style plugins
Comment 4 Simon McVittie 2012-09-07 10:32:35 UTC
Created attachment 66776 [details] [review]
mcd-dbusprop: remove support for filtering property  setting through an ACL

This provided an asynchronous API for getting and setting properties,
which nothing actually calls into, and nothing in MC supports setting
properties asynchronously anyway. Into the bin it goes!
Comment 5 Simon McVittie 2012-09-07 10:32:47 UTC
Created attachment 66777 [details] [review]
mcd_service_new: use tp_dbus_daemon_dup()
Comment 6 Simon McVittie 2012-09-07 10:33:01 UTC
Created attachment 66778 [details] [review]
Use G_VALUE_INIT instead of { 0 }

We already depend on GLib 2.30, which is new enough.
Comment 7 Simon McVittie 2012-09-07 10:33:15 UTC
Created attachment 66779 [details] [review]
Be single-include-compliant when generating service  bindings
Comment 8 Simon McVittie 2012-09-07 10:33:31 UTC
Created attachment 66780 [details] [review]
Don't generate code for Account.I.Addressing, use  telepathy-glib's
Comment 9 Xavier Claessens 2012-09-07 12:36:20 UTC
+1 to all. Awesome :)
Comment 10 Simon McVittie 2012-09-07 15:24:45 UTC
Fixed in git for 5.13.2


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.