Bug 55101

Summary: Provide GVariant-based GSocketAddress conversion
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: tp-glibAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: enhancement    
Priority: medium CC: guillaume.desmottes
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 30422    
Attachments: tp_g_socket_address_from_g_variant, tp_address_g_variant_from_g_socket_address: add

Description Simon McVittie 2012-09-19 15:04:33 UTC
Created attachment 67399 [details] [review]
tp_g_socket_address_from_g_variant,  tp_address_g_variant_from_g_socket_address: add

+++ This bug was initially created as a clone of Bug #30422 +++
Comment 1 Guillaume Desmottes 2012-09-26 10:41:51 UTC
Comment on attachment 67399 [details] [review]
tp_g_socket_address_from_g_variant,  tp_address_g_variant_from_g_socket_address: add

Review of attachment 67399 [details] [review]:
-----------------------------------------------------------------

::: telepathy-glib/gnio-util.c
@@ +294,5 @@
> + * If @variant is a floating reference, this function takes ownership
> + * of it.
> + *
> + * Returns: a newly allocated #GSocketAddress for the given variant, or %NULL
> + * on error

Missing Since:

@@ +322,5 @@
> + * Converts a #GSocketAddress to a #GVariant address variant that can be used
> + * with Telepathy.
> + *
> + * Returns: (transfer none): a new variant with a floating reference, or %NULL
> + */

Here too.
Comment 3 Simon McVittie 2012-09-26 12:48:17 UTC
++
Comment 4 Guillaume Desmottes 2012-09-26 12:52:44 UTC
Merged to master for 0.19.10 (or 0.20.0 depending on which one we release).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.