Bug 55101 - Provide GVariant-based GSocketAddress conversion
Summary: Provide GVariant-based GSocketAddress conversion
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: 30422
  Show dependency treegraph
 
Reported: 2012-09-19 15:04 UTC by Simon McVittie
Modified: 2012-09-26 12:52 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
tp_g_socket_address_from_g_variant, tp_address_g_variant_from_g_socket_address: add (8.99 KB, patch)
2012-09-19 15:04 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2012-09-19 15:04:33 UTC
Created attachment 67399 [details] [review]
tp_g_socket_address_from_g_variant,  tp_address_g_variant_from_g_socket_address: add

+++ This bug was initially created as a clone of Bug #30422 +++
Comment 1 Guillaume Desmottes 2012-09-26 10:41:51 UTC
Comment on attachment 67399 [details] [review]
tp_g_socket_address_from_g_variant,  tp_address_g_variant_from_g_socket_address: add

Review of attachment 67399 [details] [review]:
-----------------------------------------------------------------

::: telepathy-glib/gnio-util.c
@@ +294,5 @@
> + * If @variant is a floating reference, this function takes ownership
> + * of it.
> + *
> + * Returns: a newly allocated #GSocketAddress for the given variant, or %NULL
> + * on error

Missing Since:

@@ +322,5 @@
> + * Converts a #GSocketAddress to a #GVariant address variant that can be used
> + * with Telepathy.
> + *
> + * Returns: (transfer none): a new variant with a floating reference, or %NULL
> + */

Here too.
Comment 3 Simon McVittie 2012-09-26 12:48:17 UTC
++
Comment 4 Guillaume Desmottes 2012-09-26 12:52:44 UTC
Merged to master for 0.19.10 (or 0.20.0 depending on which one we release).


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.