Summary: | Fix some compile warnings | ||
---|---|---|---|
Product: | poppler | Reporter: | Hib Eris <hib> |
Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
0001-Make-sure-array-index-is-0.patch
0002-Do-not-use-mapUTF8-directly-in-CairoOutputDev.patch 0003-Split-our-UTF.h-into-xpdf-based-UTF8.h-and-a-poppler.patch |
Description
Hib Eris
2012-09-22 19:23:39 UTC
Created attachment 67553 [details] [review] 0001-Make-sure-array-index-is-0.patch This first patch I think might fix a possible buffer overflow. Created attachment 67554 [details] [review] 0002-Do-not-use-mapUTF8-directly-in-CairoOutputDev.patch This patch is necessary for the next patch. Created attachment 67555 [details] [review] 0003-Split-our-UTF.h-into-xpdf-based-UTF8.h-and-a-poppler.patch This patch brings back the original UTF8.h from xpdf and reduces poppler's UTF.h by removing the functions from UTF8.h. This fixes the warnings caused by including UTF8.h on defined but unused functions in it. As an additional bonus, it also reduces our diff with xpdf a bit. Pushed to trunk, htanks for the patches. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.