Bug 55225 - Fix some compile warnings
Summary: Fix some compile warnings
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-22 19:23 UTC by Hib Eris
Modified: 2012-10-14 21:06 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
0001-Make-sure-array-index-is-0.patch (1.18 KB, patch)
2012-09-22 19:26 UTC, Hib Eris 		Details | Splinter Review
0002-Do-not-use-mapUTF8-directly-in-CairoOutputDev.patch (2.00 KB, patch)
2012-09-22 19:27 UTC, Hib Eris 		Details | Splinter Review
0003-Split-our-UTF.h-into-xpdf-based-UTF8.h-and-a-poppler.patch (6.14 KB, patch)
2012-09-22 19:35 UTC, Hib Eris 		Details | Splinter Review
View All

Description Hib Eris 2012-09-22 19:23:39 UTC 
I have 3 patches fixing compile warnings for UTF.h/.cc. I hope you will find them usefull.
Comment 1 Hib Eris 2012-09-22 19:26:06 UTC 
Created attachment 67553 [details] [review]
0001-Make-sure-array-index-is-0.patch

This first patch I think might fix a possible buffer overflow.
Comment 2 Hib Eris 2012-09-22 19:27:48 UTC 
Created attachment 67554 [details] [review]
0002-Do-not-use-mapUTF8-directly-in-CairoOutputDev.patch

This patch is necessary for the next patch.
Comment 3 Hib Eris 2012-09-22 19:35:30 UTC 
Created attachment 67555 [details] [review]
0003-Split-our-UTF.h-into-xpdf-based-UTF8.h-and-a-poppler.patch

This patch brings back the original UTF8.h from xpdf and reduces poppler's UTF.h by removing the functions from UTF8.h.

This fixes the warnings caused by including UTF8.h on defined but unused functions in it. As an additional bonus, it also reduces our diff with xpdf a bit.
Comment 4 Albert Astals Cid 2012-10-14 21:06:09 UTC 
Pushed to trunk, htanks for the patches.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.