| Summary: | Miscellaneous clean-up of the TplLogStore API | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Will Thompson <will> |
| Component: | logger | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | nicolas |
| Version: | git master | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.com/git/user/wjt/telepathy-logger/log/?h=cleanup | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Will Thompson
2012-09-25 23:01:18 UTC
"Correct some typos in docstrings": * If an TplLogStore implementation is writable, the #TplLogManager will call - * it's tpl_log_store_add_event() method every time a loggable even occurs, - * i.e., everytime _tpl_log_manager_add_event() is called. + * its tpl_log_store_add_event() method every time a loggable even occurs, + * i.e., every time _tpl_log_manager_add_event() is called. Interesting you fixed these typos but missed "an TplLogStore" and "a loggable even"! - g_value_set_string (value, priv->name); + g_value_set_string (value, TPL_LOG_STORE_PIDGIN_NAME); You could use _set_static_string here if you wanted? Oh you remove the property later. Never mind then. Your changes look fine to me. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.