With a view to turning my proof-of-concept Google Talk IMAP log scraper into a backend in the logger, I found myself cleaning up some bits of the LogStore API which I didn't like very much. The linked branch passes its tests. I haven't actually run it for real, though.
"Correct some typos in docstrings": * If an TplLogStore implementation is writable, the #TplLogManager will call - * it's tpl_log_store_add_event() method every time a loggable even occurs, - * i.e., everytime _tpl_log_manager_add_event() is called. + * its tpl_log_store_add_event() method every time a loggable even occurs, + * i.e., every time _tpl_log_manager_add_event() is called. Interesting you fixed these typos but missed "an TplLogStore" and "a loggable even"! - g_value_set_string (value, priv->name); + g_value_set_string (value, TPL_LOG_STORE_PIDGIN_NAME); You could use _set_static_string here if you wanted? Oh you remove the property later. Never mind then. Your changes look fine to me.
http://cgit.freedesktop.org/telepathy/telepathy-logger/commit/?id=47a6af11fde8599b09eb36ec003935e40661f55e
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.