Bug 57044

commit 3a5ad21cd3f026579eeacc25b39513711556c7ee
Author: Eric Anholt <eric@anholt.net>
Date:   Mon Nov 12 19:32:58 2012 -0800

    mesa: Fix gallium build since 6991c2922f
    
    Looks like I screwed up and didn't test gallium again after tweaking the
    Makefile.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57044

Verified fixed with commit 3a5ad21cd3f026579eeacc25b39513711556c7ee, thanks.

I have what seems the same issue with current git:

  CPPAS  read_rgba_span_x86.lo
make[5]: *** No rule to make target `../../src/mesa/program/libprogram.la', needed by `libmesa.la'.  Stop.

Full build log:
https://launchpadlibrarian.net/122918035/buildlog_ubuntu-precise-i386.mesa_9.1~git1211131112.fe2ef4~gd~p_FAILEDTOBUILD.txt.gz

Let me know if I have to open a new bug.

(In reply to comment #3)
> I have what seems the same issue with current git:
> 

Same here, also with an xlib build.

The head of my build script is:

rm -rf /home/kevin/mesa_nightly/*

# Update Mesa Source
cd /home/kevin/mesa
make clean
git reset --hard
git clean -fd
git pull origin

# Make Mesa
./autogen.sh \
  --prefix=/home/kevin/mesa_nightly \
  --disable-dri \
  --enable-glx \
  --enable-xlib-glx \
  --without-gallium-drivers \
  --enable-osmesa \
  --disable-shared-glapi

(In reply to comment #1)
> commit 3a5ad21cd3f026579eeacc25b39513711556c7ee
> Author: Eric Anholt <eric@anholt.net>
> Date:   Mon Nov 12 19:32:58 2012 -0800
> 
>     mesa: Fix gallium build since 6991c2922f
>     
>     Looks like I screwed up and didn't test gallium again after tweaking the
>     Makefile.
>     
>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57044

This change doesn't seem to be correct.

Reading src/mesa/Makefile.am, it looks to me like it will need libprogram.la if NEED_LIBMESA or HAVE_GALLIUM is true.

Created attachment 70736 [details] [review]
Simple patch to fix libprogram build

Attached a patch to fix both build by introducing a new NEED_LIBPROGRAM Automake conditional

(In reply to comment #6)
> Created attachment 70736 [details] [review] [review]
> Simple patch to fix libprogram build

Confirmed working.

(In reply to comment #6)
> Created attachment 70736 [details] [review] [review]
> Simple patch to fix libprogram build
> 
> Attached a patch to fix both build by introducing a new NEED_LIBPROGRAM
> Automake conditional

I have the same problem Kevin reported in comment #4 and Quentin's patch fixes it as Fabio reported in comment #7.  Please apply or explain why it's wrong.

> Please apply or explain why it's wrong.

I agree. Applying yourself a patch is easy, but it is much less fun doing it when bisecting.

I went ahead and committed it.  Presumably no one had bothered to do it because it didn't affect their builds.

commit c5e9396424bb470ec55a2a29e3ef95aa76fed738
Author: Quentin Glidic <sardemff7+git@sardemff7.net>
Date:   Wed Nov 28 16:33:47 2012 +0100

    mesa/program: Fix both Classic and Gallium build
    
    Follow-up for 907844107252260c646aca361191ef7f121f3d23 and
    3a5ad21cd3f026579eeacc25b39513711556c7ee
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57044
    Tested-by: Fabio Pedretti <fabio.ped@libero.it>
    Tested-by: Brad King <brad.king@kitware.com>