Bug 57699

Summary: lp_test_format regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: jfonseca
Version: gitKeywords: regression
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: lp_test_format.log

Description Vinson Lee 2012-11-29 20:22:08 UTC 
Created attachment 70801 [details]
lp_test_format.log

mesa: dbd6135bc1ba285128ab991c03c4df6fbd6fefe8 (master)

9f06061d50f90bf425a5337cea1b0adb94a46d25 is the first bad commit
commit 9f06061d50f90bf425a5337cea1b0adb94a46d25
Author: José Fonseca <jfonseca@vmware.com>
Date:   Wed Nov 28 19:20:18 2012 +0000

    util/u_format: Kill util_format_is_array().
    
    It is buggy (it was giving wrong results for some of the formats with
    padding), and util_format_description::is_array already does precisely
    what's intended.
    
    Reviewed-by: Roland Scheidegger <sroland@vmware.com>

:040000 040000 acbb7501279a631c0f3e26c21f98e493fc23d551 23f59be31e2e9bdcc534e2745f0505938888bce2 M	src
bisect run success
Comment 1 Roland Scheidegger 2012-11-29 21:42:34 UTC 
Hmm yes looks like the old util_format_is_array() function did not consider anything non-rgb to be an array, whereas colorspace doesn't matter for the is_array bit. I don't know if the is_array bit should take colorspace into account or if that should be fixed in the fetch caller code.
Comment 2 Jose Fonseca 2012-12-03 14:57:21 UTC 
Fixed with 


commit 041966801ec87e3bf32913e43d6882eca9434695
Author: Roland Scheidegger <sroland@vmware.com>
Date:   Sat Dec 1 17:04:54 2012 +0100

    gallivm: fix srgb format fetch
    
    we need to rely on util code for fetching those, just like before
    9f06061d50f90bf425a5337cea1b0adb94a46d25.
    Fixes bugs 57699 and 57756.
    
    Reviewed-by: Brian Paul <brianp@vmware.com>
    Reviewed-by: José Fonseca <jfonseca@vmware.com>
Comment 3 Jose Fonseca 2012-12-03 14:58:01 UTC 
*** Bug 57756 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.